Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added: Signup view with respective url, Signup and success page. #10

Closed
wants to merge 4 commits into from
Closed

Added: Signup view with respective url, Signup and success page. #10

wants to merge 4 commits into from

Conversation

itzmanish
Copy link

@itzmanish itzmanish commented Oct 6, 2019 •
edited
Loading

Pull request for issue #2 #3 #4

SameeranB
SameeranB requested changes Oct 6, 2019
View reviewed changes
Copy link
Collaborator

@SameeranB SameeranB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You do not need a separate view for success. Just render the success.html upon successful signup.

@itzmanish
Copy link
Author

I have updated as you suggested. Now you can merge however you need to fix those conflicts that occurred by your last merge.

@itzmanish itzmanish closed this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SameeranB SameeranB Awaiting requested review from SameeranB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itzmanish @SameeranB