Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api telechargement #55

Merged
merged 43 commits into from
Sep 6, 2024
Merged

Api telechargement #55

merged 43 commits into from
Sep 6, 2024

Conversation

mmohadIGN
Copy link

Description

This PR introduces [...]

Architectural changes

The following library now depends on [...]

Screenshots

[...]

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by Organization ABC.

Naminoshin and others added 30 commits June 25, 2024 11:44
… records

This change renames the "distributions" field to "onlineResources" on
dataset records, similarly to the service records
This way, both kinds of records have the same property name, which makes sense
because this property contains a mix of online resources

The type of the online resources is different for datasets and services, but
having the property named the same should simplify things down the line
nx g component online-resource-card --project feature-editor --style=css --changeDetection=OnPush --standalone --path=libs/feature/editor/src/lib/components
The attachedResources field is not preset yet in the model and is
simply read from the facade. Eventually it might be put in its own field
for simplicity

Also adjusts the sortable list to use a proper gn-ui-button
The overview form field works similarly to the attached resources one.
The intermediary "overview-upload" component was removed and everything is done
in form-field-overviews component.
Reading the attachments on overview change has been removed as we don't delete
the attachments anymore.
…omponentOutlet

This should simplify usage and allow binding output events to the sortable
items more easily
This includes: attached-resources, temporal-extents and contacts
Renamed the attached-resources form field component to online-link-resources
to match the model terminology
@mmohadIGN mmohadIGN merged commit bf2944b into datahub-ign-2905 Sep 6, 2024
4 of 12 checks passed
Copy link

github-actions bot commented Sep 6, 2024

Affected libs: api-metadata-converter, feature-editor, api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, feature-auth, ui-search, common-domain, common-fixtures, util-shared, ui-elements, feature-notifications, ui-catalog, ui-widgets, ui-inputs, ui-layout, ui-map, ui-dataviz, database-dump, data-access-datafeeder, util-data-fetcher, util-app-config, data-access-gn4, util-i18n,
Affected apps: datahub, metadata-converter, metadata-editor, demo, webcomponents, map-viewer, search, datafeeder, data-platform,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link

github-actions bot commented Sep 6, 2024

📷 Screenshots are here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants