Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting BS4 popover selector if element is a string #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mlocati
Copy link

@mlocati mlocati commented Apr 7, 2020

As per docs, element can be a string. If so, the current code assign popOpts.selector the value #undefined (because step.element[0] returns the first char of the string, which doesn't have an id property).

Let's fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant