Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add focus highlight on gallery controls #28

Closed
wants to merge 2 commits into from

Conversation

Saira-A
Copy link

@Saira-A Saira-A commented Oct 24, 2024

Fixes UV issue #1080

Screenshot 2024-10-24 at 10 29 07

@demiankatz
Copy link
Contributor

@Saira-A, I'm a bit confused here. When I run the built-in stand-alone example for this component, the highlighting already looks fine:

image

When I switch to your branch, it actually looks worse to me:

image

Are you testing this in a different way? Is it possible that the problem is actually not with this component itself but rather with some UV style that is conflicting with the component's styles?

@Saira-A
Copy link
Author

Saira-A commented Oct 24, 2024

@Saira-A, I'm a bit confused here. When I run the built-in stand-alone example for this component, the highlighting already looks fine:

image

When I switch to your branch, it actually looks worse to me:

image

Are you testing this in a different way? Is it possible that the problem is actually not with this component itself but rather with some UV style that is conflicting with the component's styles?

You're right, I'll close this and do it directly in UV instead

@Saira-A Saira-A closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants