Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 5 col podcasts widget #77

Merged
merged 7 commits into from
Dec 6, 2019
Merged

Adds 5 col podcasts widget #77

merged 7 commits into from
Dec 6, 2019

Conversation

joshdarby
Copy link

@joshdarby joshdarby commented Nov 19, 2019

Changes

This pull request makes the following changes:

  • Adds the Borderzine Five-Column Podcasts widget to display podcasts
  • Adds a custom widget-content.php to the child theme to show the play icon for podcast posts

Screen Shot 2019-11-19 at 2 07 22 PM

Why

For #45

Testing/Questions

Features that this PR affects:

  • The new 5 col podcasts widget

Questions that need to be answered before merging:

  • Is this PR targeting the correct branch in this repository?
  • Would it be a good idea to add a checkbox to the widget to toggle the play icon on/off? Might be useful if there's ever a need for this 5 col widget for posts that are not podcasts

Steps to test this PR:

  1. Add the ``Borderzine Five-Column Podcasts` widget to a test series landing page widget area
  2. Set it to:
    • number: 5 or 10
    • avoid duplicates: yes
    • excerpt: no
    • byline: no
    • top term: no
    • limit to author: none
    • limit to category: none
    • limit to tags: none
    • link text: View All
    • URL: a test url

@joshdarby joshdarby requested a review from benlk November 19, 2019 19:14
@joshdarby joshdarby self-assigned this Nov 19, 2019
@joshdarby joshdarby merged commit ba1be4d into master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants