chore: Update CI python version from 3.6 to 3.11 #5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
I-Al-Istannen
changed the title
|
Is there a reason we don't upgrade to the newest python version? I'm kind of out of the loop for python and if the break APIs we use. |
|
I consider the python version in the CI some kind of "we support at least Version X" guarantee (as we see breakages directly in our CI). According to repology, a few are still on 3.9: https://repology.org/project/python/versions. Our python files are small and simple, upgrading for us should be basically free. I'm fine with 3.11 as well. |
I-Al-Istannen
force-pushed
the
chore/upgrade-ci-python-version
branch
from
efbd850
to
dcc4508
Compare
I-Al-Istannen
changed the title
MartinWitt
approved these changes
Nov 28, 2022
MartinWitt
changed the title
|
Thanks @I-Al-Istannen |
|
We only use Python for scripts so we hardly need to care about... Anything. If it runs, it runs. There are a lot of breaking changes between 3.6 and 3.11 (especially when it comes to third party packages), but again, if our CI runs we're good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github recently updated their
ubuntu-latestimage to 22.04. This broke setup-python as it no python 3.6 tarball is provided (actions/setup-python#544).This PR fixes the issue by just updating the CI to use python 3.9. It does not adjust the ci scripts to take advantage of possible new python features introduced since then.
This breakage is responsible for the current red master (as the PR run was executed before the Github runner change but the master action ran after it) and unblocks some PRs.
I also needed to update commonmark. Note that commonmark is deprecated for over a year now: readthedocs/commonmark.py#308. We might to want migrate away from it in a future PR, though we don't really need to. The source code we analyze is benign so security isn't really an issue and the featureset is enough for us.