-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reduce search providers per config value "unified_search_providers_allowed" #46
Conversation
4ec4127
to
0dc5932
Compare
680e17c
to
85cf023
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review OK
85cf023
to
e922e08
Compare
….providers_allowed reduce search providers by setting core config value to unified_search.providers_allowed = [ 'files', 'setting' ] ./occ config:app:set --value '["files","settings"]' --type array core unified_search.providers_allowed Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
1eecc79
to
1e49969
Compare
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
1e49969
to
9383010
Compare
Summary
This feature should help to restrict not desired search providers by allowing only desired search providers.
Before
One can see the
/ocs/v2.php/search/providers
deliver various search providers (you may see other providers on your nextcloud instance depending on installed/disabled apps).After feature activation
One can see we allowed only the
files
andsettings
search providers (since we do not want to allow any other search providers).CLI Example: restrict search providers to
files
andsettings
unified_search.providers_allowed
unified_search.providers_allowed=[ 'files', 'setting' ]
./occ config:app:set --value '["files","settings"]' --type array core unified_search.providers_allowed
initial config happens via
IONOS/first-time-configure.sh
override of translate in
nc-server/core/src/components/UnifiedSearch/UnifiedSearchModal.vue
Line 26 in b5b3016
nc_theming
app in order not to conflict with core translate filesproposed search providers configuration to nextcloud feat: reduce search providers per config value "unified_search_providers_allowed" nextcloud/server#48841
TODO
Checklist