Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce search providers per config value "unified_search_providers_allowed" #46

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

printminion-co
Copy link

@printminion-co printminion-co commented Oct 11, 2024

Summary

This feature should help to restrict not desired search providers by allowing only desired search providers.

Before

One can see the /ocs/v2.php/search/providers deliver various search providers (you may see other providers on your nextcloud instance depending on installed/disabled apps).
Selection_20241023-002

After feature activation

One can see we allowed only the files and settings search providers (since we do not want to allow any other search providers).

Selection_20241023-003

CLI Example: restrict search providers to files and settings

  • override happens via app core config unified_search.providers_allowed
    • reduce search providers by setting core app config value to unified_search.providers_allowed=[ 'files', 'setting' ]
./occ config:app:set --value '["files","settings"]' --type array core unified_search.providers_allowed

TODO

Checklist

@printminion-co printminion-co changed the title Mk/dev/search files only reduce search providers Oct 11, 2024
@printminion-co printminion-co force-pushed the mk/dev/search_files_only branch 3 times, most recently from 4ec4127 to 0dc5932 Compare October 22, 2024 13:35
@printminion-co printminion-co force-pushed the mk/dev/search_files_only branch 3 times, most recently from 680e17c to 85cf023 Compare October 23, 2024 08:04
@printminion-co printminion-co changed the title reduce search providers feat: reduce search providers per config value "unified_search_providers_allowed" Oct 23, 2024
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link

@fracado fracado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review OK

….providers_allowed

reduce search providers by setting core config value to unified_search.providers_allowed = [ 'files', 'setting' ]

./occ config:app:set --value '["files","settings"]' --type array core unified_search.providers_allowed

Signed-off-by: Misha M.-Kupriyanov <[email protected]>
@printminion-co printminion-co force-pushed the mk/dev/search_files_only branch 2 times, most recently from 1eecc79 to 1e49969 Compare October 28, 2024 11:59
@printminion-co printminion-co merged commit bdb5b84 into ionos-dev Oct 28, 2024
4 of 5 checks passed
@printminion-co printminion-co deleted the mk/dev/search_files_only branch October 28, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants