Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mmap the CompletionQueueEvent #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix mmap the CompletionQueueEvent #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 21 additions & 24 deletions mmap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
var (
uint32Size = uint32(unsafe.Sizeof(uint32(0)))
sqeSize = uint32(unsafe.Sizeof(iouring_syscall.SubmissionQueueEntry{}))
cqeSize = uint32(unsafe.Sizeof(iouring_syscall.CompletionQueueEvent{}))
)

func mmapIOURing(iour *IOURing) (err error) {
Expand All @@ -26,30 +27,36 @@ func mmapIOURing(iour *IOURing) (err error) {
iour.sq = new(SubmissionQueue)
iour.cq = new(CompletionQueue)

if err = mmapSQ(iour); err != nil {
iour.sq.size = iour.params.SQOffset.Array + iour.params.SQEntries*uint32Size
iour.cq.size = iour.params.CQOffset.Cqes + iour.params.CQEntries*cqeSize
if (iour.params.Features & iouring_syscall.IORING_FEAT_SINGLE_MMAP) != 0 {
if iour.cq.size > iour.sq.size {
iour.sq.size = iour.cq.size
} else {
iour.cq.size = iour.sq.size
}
}

if err = mmapSQ(iour.fd, iour.params, iour.sq); err != nil {
return err
}

if (iour.params.Features & iouring_syscall.IORING_FEAT_SINGLE_MMAP) != 0 {
iour.cq.ptr = iour.sq.ptr
}

if err = mmapCQ(iour); err != nil {
if err = mmapCQ(iour.fd, iour.params, iour.cq); err != nil {
return err
}

if err = mmapSQEs(iour); err != nil {
if err = mmapSQEs(iour.fd, iour.params, iour.sq); err != nil {
return err
}
return nil
}

func mmapSQ(iour *IOURing) (err error) {
sq := iour.sq
params := iour.params

sq.size = params.SQOffset.Array + params.SQEntries*uint32Size
sq.ptr, err = mmap(iour.fd, sq.size, iouring_syscall.IORING_OFF_SQ_RING)
func mmapSQ(fd int, params *iouring_syscall.IOURingParams, sq *SubmissionQueue) (err error) {
sq.ptr, err = mmap(fd, sq.size, iouring_syscall.IORING_OFF_SQ_RING)
if err != nil {
return fmt.Errorf("mmap sq ring: %w", err)
}
Expand All @@ -66,17 +73,12 @@ func mmapSQ(iour *IOURing) (err error) {
Len: int(params.SQEntries),
Cap: int(params.SQEntries),
}))

return nil
}

func mmapCQ(iour *IOURing) (err error) {
params := iour.params
cq := iour.cq

cq.size = params.CQOffset.Cqes + params.CQEntries*uint32Size
func mmapCQ(fd int, params *iouring_syscall.IOURingParams, cq *CompletionQueue) (err error) {
if cq.ptr == 0 {
cq.ptr, err = mmap(iour.fd, cq.size, iouring_syscall.IORING_OFF_CQ_RING)
cq.ptr, err = mmap(fd, cq.size, iouring_syscall.IORING_OFF_CQ_RING)
if err != nil {
return fmt.Errorf("mmap cq ring: %w", err)
}
Expand All @@ -94,25 +96,21 @@ func mmapCQ(iour *IOURing) (err error) {
Len: int(params.CQEntries),
Cap: int(params.CQEntries),
}))

return nil
}

func mmapSQEs(iour *IOURing) error {
params := iour.params

ptr, err := mmap(iour.fd, params.SQEntries*sqeSize, iouring_syscall.IORING_OFF_SQES)
func mmapSQEs(fd int, params *iouring_syscall.IOURingParams, sq *SubmissionQueue) (err error) {
ptr, err := mmap(fd, params.SQEntries*sqeSize, iouring_syscall.IORING_OFF_SQES)
if err != nil {
return fmt.Errorf("mmap sqe array: %w", err)
}

iour.sq.sqes = *(*[]iouring_syscall.SubmissionQueueEntry)(
sq.sqes = *(*[]iouring_syscall.SubmissionQueueEntry)(
unsafe.Pointer(&reflect.SliceHeader{
Data: ptr,
Len: int(params.SQEntries),
Cap: int(params.SQEntries),
}))

return nil
}

Expand Down Expand Up @@ -141,7 +139,6 @@ func munmapIOURing(iour *IOURing) error {
}
iour.cq = nil
}

return nil
}

Expand Down