Update: 1.3.0-floweditor-1.18.4 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added a bit of styling to the advanced tab - added dial limit and call limit to the advanced tab - added dial limit and call limit to the wait JSON
- updated existing unit test snapshot - added placeholders for unit tests
- fixed call limit handler method typo - added placeholder to each text input - minor update to position of __className in list of elem attrs - added todo's to scss
- removed extra unused style rules (but keeping style file for now) - using vanilla p element instead of TextInputElement showLabel attribute for dialLimit and callLimit textbox labels - removed unused TextInputElement __className attribute - added dialLimit and callLimit to helpers nodeToState? - added dialLimit and callLimit to flowTypes wait interface?
…progress
- removed extra comments in dial router form
- explicitly setting dialLimit and callLimit to themselves in setState
- switched setting dialLimit and callLimit from "StringEntry = { value: '' }" to just "" in nodeToState
- switched setting dialLimit from router.wait.dialLimit to router.wait.dial_limit in nodeToState
- switched setting callLimit from router.wait.callLimit to router.wait.call_limit in nodeToState
- no changes needed to const wait in stateToNode
- unit tests in progress
- added explicit defaults for dialLimit and callLimit - switched from StringEntry to NumberEntry - unit tests in progress
…/nyaruka/floweditor into sl-dial-router-form-advanced-tab
- switched from string to number - removed extra casting/conversion
- added tests for dial limit and call limit - removed i18n.t() from TextInputElement name attr value - updated createDialRouter to add dialLimit and callLimit args - updated snapshot
- fixed originalArgument var name typo - fixed bug where rule translations tab wasn't displaying "has number between" arguments correctly
- added truthy filter to kase.arguments just before the check for any kase.arguments
…one else in a flow form
- switched from temba-checkbox to CheckboxElement - added update logic for skipContactsInFlow in StartSessionForm handleUpdate fn - added init logic for skipContactsInFlow in helpers initializeForm fn - added skipContactsInFlow to helpers stateToAction fn's action object - added skipContactsInFlow to flowTypes StartSession interface - added skipContactsInFlow to assetCreators createStartSessionAction
…ruka/floweditor into sl-has-number-between-bugfix
- also moved checkbox into advanced tab
- tentatively created ExclusionsCheckboxEntry to abstract and DRY things out a bit - updated unit tests
…gfix wait for response form - numeric rule - rule translations tab - has number between and empty translations bugfixes
…kip-support start somebody else in a flow form - add skip contacts in a flow checkbox
- added margin and width styling to flex items
- now only adding margin-right to first child - now only adding margin-left to last child
- and also added back the generic .flex_items margins in case we ever add anything in between the first and last child and need those items to maintain the same margins
…nced-tab dial router form - new advanced tab with dial limit and call limit values
…es-from-translations excluding all date, time, and numeric rules from translations
Disallow groups on start session action
Fix StartSessionForm bug for definitions without exclusions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 63.52% 63.62% +0.09%
==========================================
Files 177 177
Lines 6915 6942 +27
Branches 1650 1657 +7
==========================================
+ Hits 4393 4417 +24
- Misses 1936 1940 +4
+ Partials 586 585 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.