Skip to content

Commit

Permalink
chore: Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ismael González Valverde <[email protected]>
  • Loading branch information
hielfx and ismaelgonval authored Jun 11, 2024
1 parent 9b2dc82 commit 399125b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/USAGE.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ gh sherpa create-branch, cb [flags]
#### Optional parameters

* `--base`: Base branch for checkout. By default is the default branch.
* `--no-fetch`: The base branch and current branch will not be fetched.
* `--no-fetch`: Remote branches will not be fetched.
* `--yes, -y`: The branch will be created without confirmation.

### Possible scenarios
Expand Down Expand Up @@ -81,7 +81,7 @@ gh sherpa create-pr, cpr [flags]

* `--issue, -i`: GitHub or Jira issue identifier.
* `--base`: Base branch for checkout. By default is the default branch.
* `--no-fetch`: The base branch and current branch will not be fetched.
* `--no-fetch`: Remote branches will not be fetched.
* `--yes, -y`: The pull request will be created without confirmation.
* `--no-draft`: The pull request will be created in ready for review mode. By default is in draft mode.
* `--no-close-issue`: The GitHub issue will not be closed when the pull request is merged. By default is closed.
Expand Down
2 changes: 1 addition & 1 deletion internal/use_cases/create_pull_request.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func (cpr CreatePullRequest) Execute() error {
return err
}

// After stablishing the branch, fetch it to get the latest chages.
// After stablishing the branch, fetch it to get the latest changes.
// We don't check the error because the branch may not exist in the
// remote repository.
_ = cpr.fetchBranch(currentBranch)
Expand Down

0 comments on commit 399125b

Please sign in to comment.