Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch Name Length Control Configurable #93

Merged
merged 10 commits into from
Jun 6, 2024

Conversation

hielfx
Copy link
Member

@hielfx hielfx commented Jun 6, 2024

Closes #77

@hielfx hielfx added the kind/feature Changes implying a new feature for the user label Jun 6, 2024
@hielfx hielfx marked this pull request as ready for review June 6, 2024 15:08
@hielfx hielfx requested a review from a team as a code owner June 6, 2024 15:08
Copy link
Contributor

@ismaelgonval ismaelgonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look great! Some minor comments.

internal/config/default-config.yml Outdated Show resolved Hide resolved
internal/config/default-config.yml Outdated Show resolved Hide resolved
pkg/validator/error_messages.go Outdated Show resolved Hide resolved
ismaelgonval
ismaelgonval previously approved these changes Jun 6, 2024
Copy link

sonarcloud bot commented Jun 6, 2024

@hielfx hielfx merged commit 2fa2c6e into main Jun 6, 2024
4 checks passed
@hielfx hielfx deleted the feature/GH-77-branch-name-length-control-c branch June 6, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Changes implying a new feature for the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Branch Name Length Control Configurable
2 participants