support having #171
Open
support having #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emakarov
reviewed
May 19, 2021
src/infi/clickhouse_orm/query.py
Outdated
| @@ -392,6 +393,9 @@ def as_sql(self): | |||
| if self._grouping_with_totals: | |||
| sql += ' WITH TOTALS' | |||
|
|
|||
| if self._having: | |||
| sql += '\nhaving ' + self.having_as_sql() | |||
There was a problem hiding this comment.
it makes sense to use caps i.e. HAVING in order to keep the style
emakarov
reviewed
May 20, 2021
src/infi/clickhouse_orm/query.py
Outdated
| @@ -442,6 +452,14 @@ def order_by(self, *field_names): | |||
| qs._order_by = field_names | |||
| return qs | |||
|
|
|||
| def having(self, having_str): | |||
There was a problem hiding this comment.
what is having_str ?
are you proposing to provide a condition just as a string?
It's a bit changing the concept of ORM, unlike when we do filter there is kwargs approach
There was a problem hiding this comment.
I use Q function to support HAVING. Thanks to check it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.