feat: BooleanField for ORM #206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrisMinhas123
changed the title
SyedWaqarD4I
approved these changes
Aug 1, 2023
emakarov
reviewed
Aug 1, 2023
src/infi/clickhouse_orm/fields.py
Outdated
| @@ -162,7 +162,25 @@ def validate(self, value): | |||
| if len(value) > self._length: | |||
| raise ValueError('Value of %d bytes is too long for FixedStringField(%d)' % (len(value), self._length)) | |||
|
|
|||
| class BooleanField(Field): | |||
| # The ClickHouse column type to use | |||
| db_type = 'UInt8' | |||
There was a problem hiding this comment.
ClickHouse has type bool https://clickhouse.com/docs/en/sql-reference/data-types/boolean while it's kept internally as UInt8, why not set here db_type = 'Bool' ?
There was a problem hiding this comment.
DB type has been changed to Bool as suggested. It doesnt make any difference functionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.