Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Edge authentication support #111

Merged
merged 8 commits into from
Aug 5, 2024
Merged

Conversation

alespour
Copy link
Contributor

@alespour alespour commented Jul 31, 2024

Proposed Changes

Adds authScheme option to InfluxDBClient initialization (via config, connection string or environment variables) to allow setting token authentication scheme other then the default "Token" (used for Cloud). For Edge (OSS), users need to set it to "Bearer".

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.81%. Comparing base (c0e42c8) to head (77c49c2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   89.29%   95.81%   +6.51%     
==========================================
  Files          12       12              
  Lines        1093     1098       +5     
  Branches      140      141       +1     
==========================================
+ Hits          976     1052      +76     
+ Misses         80       11      -69     
+ Partials       37       35       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alespour alespour marked this pull request as ready for review July 31, 2024 09:50
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! 👍 Before we can proceed with accepting it, there are a few requirements that need to be met:

Client/InfluxDBClient.cs Outdated Show resolved Hide resolved
Client/InfluxDBClient.cs Outdated Show resolved Hide resolved
@alespour alespour requested a review from bednar August 5, 2024 12:41
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@alespour alespour merged commit 9fba8a2 into main Aug 5, 2024
10 checks passed
@alespour alespour deleted the fix/edge-authentication branch August 5, 2024 12:49
@bednar bednar added this to the 0.7.0 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants