Address review comments for InnerSource Hackathon pattern #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sebastian Spier <[email protected]>
Co-authored-by: Sebastian Spier <[email protected]>
Co-authored-by: Sebastian Spier <[email protected]>
Co-authored-by: Sebastian Spier <[email protected]>
spriya-m
requested review from
lenucksi,
NewMexicoKid,
cewilliams,
spier,
robtuley and
yuhattor
as code owners
spier
reviewed
Oct 7, 2024
| @@ -16,10 +16,10 @@ The company wants to adopt InnerSource as software development methodology but o | |||
|
|
|||
| The senior leadership believes in InnerSource and wants to drive it throughout the company. The engineers who are familiar with open source principles and/or understand the benefits of InnerSource are the early adopters. There is success with these initial pilot project and teams. Now the next step is to drive it across the company. There might be reluctance from engineering teams due to various factors like: | |||
|
|
|||
| * not familiar with InnerSource and being ignorant to know about it | |||
| * not familiar with InnerSource and not aware about it | |||
There was a problem hiding this comment.
"not familiar" and "not aware" sounds like saying the same thing twice now. I am not sure though.
I have also asked in the thread in slack if anybody has a better proposal.
| * not enough time to prioritize InnerSource, given the regular work deliverables | ||
| * relunctance to changing ways of working when everything works well already | ||
| * perception that InnerSource requires more work and responsibilities | ||
| * unclear ROI for the upfront setup innersourcing takes |
There was a problem hiding this comment.
Suggested change
| * unclear ROI for the upfront setup innersourcing takes | |
| * unclear return on investment for the upfront setup costs that an InnerSource project takes |
We try to stick to the spelling InnerSource, wherever possible. See explanation.
Also I removed an acronym and elaborated on the sentence a bit
spier
added
1-initial
spier
reviewed
Oct 9, 2024
spier
reviewed
Oct 9, 2024
| @@ -16,10 +16,10 @@ The company wants to adopt InnerSource as software development methodology but o | |||
|
|
|||
| The senior leadership believes in InnerSource and wants to drive it throughout the company. The engineers who are familiar with open source principles and/or understand the benefits of InnerSource are the early adopters. There is success with these initial pilot project and teams. Now the next step is to drive it across the company. There might be reluctance from engineering teams due to various factors like: | |||
There was a problem hiding this comment.
Suggested change
| The senior leadership believes in InnerSource and wants to drive it throughout the company. The engineers who are familiar with open source principles and/or understand the benefits of InnerSource are the early adopters. There is success with these initial pilot project and teams. Now the next step is to drive it across the company. There might be reluctance from engineering teams due to various factors like: | |
| The senior leadership believes in InnerSource and wants to drive it throughout the company. The engineers who are familiar with open source principles and/or understand the benefits of InnerSource are the early adopters. There is success with these initial pilot project and teams. | |
| Now the next step is to drive it across the company. There might be reluctance from engineering teams due to various factors like: |
Splitting this into 2 paragraphs to make it easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing reviewing comments by Sally Deering on this pattern