Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/radix sort #1867

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Feature/radix sort #1867

wants to merge 19 commits into from

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    830f428 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a6d51af View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    3517745 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dbe62d0 View commit details
    Browse the repository at this point in the history
  3. Add license headers

    Add common typedef for sort_contig_fn_ptr_t from merge_sort header
    and radix_sort header files into a new file.
    Used it in cpp files.
    oleksandr-pavlyk committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6d33867 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e274c2d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c2f8486 View commit details
    Browse the repository at this point in the history
  6. Add support for kind keyword in sort/argsort

    Supported values for kind are "radixsort", "mergesort", "stable".
    The default is None (same as "stable").
    
    For stable, radix sort is used for bool, (u)int8, (u)int16.
    
    Radix sort is supported for integral, boolean and real floating point
    types.
    oleksandr-pavlyk committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a15e4aa View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2684651 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    662b46b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fef0fe4 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    3c05c1b View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Change to pass sorting direction as call argument, not template param…

    …eter
    
    The intent is to reduce the build time, build memory footprint, and
    binary size of the sorting_impl module.
    
    With this change it stands at 46MB, before it was 72MB.
    oleksandr-pavlyk committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    bbe1019 View commit details
    Browse the repository at this point in the history
  2. Moved radix sort Python API to dedicated module, _tensor_sorting_radi…

    …x_impl
    
    With this change, _tensor_sorting_impl goes back to 17MB, and
    _tensor_sorting_radix_impl is 30MB. The memory footprint of linking
    should be greatly reduced, speeding up the building process,
    reducing the required memory footprint, and providing better
    parallelisation opportunities for the build job.
    
    The build time on my Core i7 reduced from 45 minutes to 33 minutes.
    oleksandr-pavlyk committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    ec6a930 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1883 from IntelPython/change-descending-from-temp…

    …late-parameter-to-an-argument
    
    Change descending from template parameter to an argument
    oleksandr-pavlyk authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    d63dd70 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2024

  1. Address PR feedback

    sort.cpp -> merge_sort.cpp, argsort.cpp -> merge_argsort.cpp
    
    Refined exception texts thrown when implementation function
    pointer is found missing.
    oleksandr-pavlyk committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    446ce05 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    93db58a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    350738b View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    09236c9 View commit details
    Browse the repository at this point in the history