Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete remove defaults channel step from test_windows job #1886

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Delete remove defaults channel step from test_windows job #1886

wants to merge 2 commits into from

Conversation

oleksandr-pavlyk
Copy link
Collaborator

The setup-miniconda action is removing 'defaults' channels now, and attempt at repeated removal trips an error.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

View rendered docs @ https://intelpython.github.io/dpctl/pulls/1886/index.html

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_171 ran successfully.
Passed: 895
Failed: 0
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Nov 6, 2024 •
edited
Loading

Coverage Status

coverage: 87.686%. remained the same
when pulling 24dfea8 on fix-workflow-step-test-windows
into 7ffcca4 on master.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_172 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

antonwolfy
antonwolfy approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ndgrigorian
ndgrigorian approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oleksandr-pavlyk @coveralls @ndgrigorian @antonwolfy