fix: anglecolor #3043
Open
fix: anglecolor #3043
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dordsor21
reviewed
Dec 24, 2024
| @@ -409,6 +409,11 @@ public BiomeType getBiomeType(int x, int y, int z) { | |||
| return getExtent().getBiomeType(x, y, z); | |||
| } | |||
|
|
|||
| @Override | |||
| public BiomeType getBiome(final BlockVector3 position) { | |||
There was a problem hiding this comment.
Are there potentially other places we need to add the override/load?
There was a problem hiding this comment.
Haven't seen any other occurrences in implementations, which would need that. I could've potentially implemented that in FilterBlock.java - but that could result in a Stackoverflow, if getBiomeType / getBiome is not properly implemented (due to getBiomeType maybe delegating to getBiome, which defaults to getBiomeType)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #3032
Submitter Checklist