Merge pull request #11 from Intentface/fix-update-calling

Fix erroneus onUpdate and onError calls
Intentface · Sep 6, 2024 · 91e7f18 · 91e7f18
2 parents 10f3aca + df4b3a1
commit 91e7f18
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/great-rules-sleep.md b/.changeset/great-rules-sleep.md
@@ -0,0 +1,5 @@
+---
+"@intentface/react-speech-recognition": patch
+---
+
+Fix situation where we call onUpdate and onError even when there is no support for speech recognition
diff --git a/index.ts b/index.ts
@@ -110,12 +110,14 @@ export function useSpeechRecognition({
   }, [SpeechRecognition, continuous, lang, timeout]);
 
   useEffect(() => {
+    if (!SpeechRecognition) return;
     if (onUpdate) onUpdate({ transcript, interimTranscript, isFinal });
-  }, [onUpdate, transcript, interimTranscript, isFinal]);
+  }, [onUpdate, transcript, interimTranscript, isFinal, SpeechRecognition]);
 
   useEffect(() => {
+    if (!SpeechRecognition) return;
     if (onError) onError({ error });
-  }, [onError, error]);
+  }, [onError, error, SpeechRecognition]);
 
   const start = useCallback(() => {
     if (!recognitionRef.current) return;