Enable JS GHA #254
Merged
Enable JS GHA #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishmack
force-pushed
the
hkm/js-enable
branch
from
3caf9c2
to
995fe04
Compare
hamishmack
force-pushed
the
hkm/js-enable
branch
from
537282d
to
3e2f04d
Compare
|
Should we have a test that verifies that the produced JS package actually works? |
|
It does run some tests here https://github.com/IntersectMBO/cardano-addresses/actions/runs/9476515970/job/26109526344?pr=254#step:6:1 They are defined in api.test.ts |
hamishmack
requested review from
paweljakubas,
Anviking,
HeinrichApfelmus,
jonathanknowles and
Unisay
as code owners
angerman
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.