Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When I tried cloning this GitHub repo, I straight way got the following issue:
ext4
has a path limit of 255 bytes and that relative path has already 171 characters, so it is very easy to exceed the limit when trying to clone the project into an already moderately long subdir. This gets worse on top of other filesystems likeecryptfs
Solution
In order to improve portability, this PR renames the golden files to only contain the first 8 characters of the base16 encoding of the result of hashing the mnemonic key using
sha3_256
instead of inlining the actual mnemonic key. It also adds a missing_
(underscore) in the name ofinspects*
files for consistency with theaddresses_*
files.