Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce Cabal dependency in byron package #4682

Closed
wants to merge 1 commit into from

Conversation

teodanciu
Copy link
Contributor

in order to avoid an error when releasing the package

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages.
    New section is never added with the code changes. (See RELEASING.md)
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated.
    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

To prevent this error in the Chap build:

   > Configuring library for cabal-doctest-1.0.10..
   > Error:
   >     The following packages are broken because other packages they depend on are missing. These broken packages must be rebuilt before they can be used.
   > installed package Cabal-3.2.1.0 is broken due to missing package parsec-3.1.14.0, text-1.2.4.1
   >
   For full logs, run 'nix log /nix/store/r6jgcm89wc2czyqmwggjlycb56kdhk4k-cabal-doctest-lib-cabal-doctest-1.0.10.drv'.

error: 1 dependencies of derivation '/nix/store/672afr0iq9qnfxpv42pb1jv7a3ih5b12-pretty-simple-4.1.2.0-setup.drv' failed to build
building '/nix/store/hp9m0cfxc3h0fpa836k43nhkwjwmvzcl-call-stack-lib-call-stack-0.4.0.drv'...
error: 1 dependencies of derivation '/nix/store/s5hcv2p2bjmz9dndx13qz2ljg9mgj91x-pretty-simple-lib-pretty-simple-4.1.2.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/a9ys8di4hdv91z78x24313cihpn0vi5n-ouroboros-consensus-lib-unstable-consensus-testlib-0.20.1.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/qykliwqawv67lsck80pwzi2bg4wg0i1h-ouroboros-network-testing-lib-ouroboros-network-testing-0.7.0.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/d2bgl2kmiq84bj3yq8i8nnkkgy1d84bb-ouroboros-consensus-cardano-lib-unstable-byron-testlib-0.19.0.0.drv' failed to build

@teodanciu teodanciu requested a review from a team as a code owner October 11, 2024 17:14
@teodanciu teodanciu force-pushed the td/fix-byron-release branch 2 times, most recently from eb6239d to 0c786ac Compare October 11, 2024 17:33
in order to avoid an error when releasing the package
@Lucsanszky
Copy link
Contributor

We can do this as a revision in cardano-haskell-packages. I'll add the changes to your open PR there and if it works out, we can close this.

@Lucsanszky
Copy link
Contributor

IntersectMBO/cardano-haskell-packages#925 now builds with the revision, so this PR won't be needed. Closing.

@Lucsanszky Lucsanszky closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants