Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix build fixes #2184

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Nix build fixes #2184

wants to merge 4 commits into from
+794 −5,412

Conversation

johnalotoski
Copy link

List of changes

  • Fixes nix builds for frontend and backend components
    • Required node_nixpkgs pin update and regeneration of yarn.lock
  • Fixes impure nix builds required by some deployers by adding an optional returnShellEnv bool to the backend package

Checklist

  • My changes generate no new warnings
  • I have commented my code, particularly in hard-to-understand areas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@jankun4 jankun4 Awaiting requested review from jankun4 jankun4 is a code owner

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@johnalotoski