Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the plate out of the profile name #33

Closed
nachtjasmin opened this issue May 30, 2023 · 3 comments · Fixed by #40
Closed

Move the plate out of the profile name #33

nachtjasmin opened this issue May 30, 2023 · 3 comments · Fixed by #40
Labels
enhancement New feature or request

Comments

@nachtjasmin
Copy link
Contributor

nachtjasmin commented May 30, 2023

Right now, we add an anchor inside an anchor. This is a major accessibility issue.

We should not add the plate to the same a tag as the name, it should be clickable on its own.

@nachtjasmin nachtjasmin added the enhancement New feature or request label May 30, 2023
@ItsVipra
Copy link
Owner

i don't see how the first is related to the second, but extracting out of the display name is basically the same as #1

@nachtjasmin
Copy link
Contributor Author

maybe I wasn't clear enough, does the edited description help? ^^

@nachtjasmin nachtjasmin changed the title Extract pronouns from profile name Move the plate out of the profile name May 30, 2023
@ItsVipra
Copy link
Owner

as in make it a sibling of strong.display-name__html? yeah we can do that, just gotta make sure it still looks nice then :3

@nachtjasmin nachtjasmin linked a pull request Jul 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants