Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework pronoun extraction #40

Merged
merged 16 commits into from
Jul 14, 2023
Merged

Rework pronoun extraction #40

merged 16 commits into from
Jul 14, 2023

Conversation

nachtjasmin
Copy link
Contributor

@nachtjasmin nachtjasmin commented Jul 10, 2023 •
edited
Loading

Closes #39, #35, #28, #7.

@nachtjasmin nachtjasmin force-pushed the rework-pronoun-field-matching branch from 4d8477f to 789fc23 Compare July 10, 2023 17:54
This was linked to issues Jul 10, 2023
Add pronouns.page support #7
Closed
Prefer plaintext pronouns to link #28
Closed
Add pronouns.within.lgbt support #35
Closed
@nachtjasmin nachtjasmin force-pushed the rework-pronoun-field-matching branch from 0d977d6 to c94df6c Compare July 10, 2023 20:53
@nachtjasmin nachtjasmin marked this pull request as ready for review July 10, 2023 20:53
@nachtjasmin nachtjasmin added the enhancement New feature or request label Jul 10, 2023
@nachtjasmin nachtjasmin force-pushed the rework-pronoun-field-matching branch from c94df6c to 4d416ea Compare July 10, 2023 21:07
@nachtjasmin nachtjasmin force-pushed the rework-pronoun-field-matching branch from 4d416ea to fac1c71 Compare July 10, 2023 22:08
@nachtjasmin
Copy link
Contributor Author

nachtjasmin commented Jul 11, 2023 •
edited
Loading

pronoun.page support with only profiles is not working for some reason.
example account: https://queer.group/@[email protected]/

fixed it. permission was missing.

@nachtjasmin nachtjasmin force-pushed the rework-pronoun-field-matching branch from e75f42d to 1405dc5 Compare July 11, 2023 15:39
se4598
se4598 reviewed Jul 11, 2023
View reviewed changes
src/libs/pronouns.js Outdated Show resolved Hide resolved
@nachtjasmin nachtjasmin force-pushed the rework-pronoun-field-matching branch from b2b57f5 to 431dcd4 Compare July 13, 2023 15:02
@nachtjasmin
Copy link
Contributor Author

Just realised that we can also close #33 with it. We don't have HTML in our pronouns anymore, so we could also get rid of setting the innerHTML.

gonna provide a commit with that soon.

@nachtjasmin nachtjasmin linked an issue Jul 14, 2023 that may be closed by this pull request
Move the plate out of the profile name #33
Closed
@nachtjasmin
Copy link
Contributor Author

Also, this method should be moved to pronouns.js.

ItsVipra
ItsVipra reviewed Jul 14, 2023
View reviewed changes
src/libs/pronouns.js Outdated Show resolved Hide resolved
@ItsVipra
Copy link
Owner

ItsVipra commented Jul 14, 2023 •
edited
Loading

Just realised that we can also close #33 with it. We don't have HTML in our pronouns anymore, so we could also get rid of setting the innerHTML.

gonna provide a commit with that soon.

but the plate itself is still in the a tag - which was the original issue you had, right?
image

EDIT: ah no the issue was that we had an anchor in an anchor, which is no longer the case - my bad

@ItsVipra ItsVipra merged commit 28921ce into main Jul 14, 2023
3 checks passed
@nachtjasmin nachtjasmin linked an issue Jul 14, 2023 that may be closed by this pull request
Ensure possessive pronoun for pronoun.page links #44
Closed
@ItsVipra ItsVipra deleted the rework-pronoun-field-matching branch July 17, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@se4598 se4598 se4598 left review comments

@ItsVipra ItsVipra ItsVipra left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@nachtjasmin @ItsVipra @se4598