Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust matching regex to catch fewer unrelated words #46

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Adjust matching regex to catch fewer unrelated words #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d16c368
Adjust matching regex to catch less unrelated words
aurorasmiles Jul 15, 2023
20fab68
Add tests for wrong matches
nachtjasmin Jul 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/pronouns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import sanitizeHtml from "sanitize-html";

const fieldMatchers = [/pro.*nouns?/i, "pronomen"];
const fieldMatchers = [/\bpro.*nouns?\b/i, "pronomen"];
const knownPronounUrls = [
/pronouns\.page\/:?([\w/@]+)/,
/pronouns\.within\.lgbt\/([\w/]+)/,
Expand Down
12 changes: 12 additions & 0 deletions tests/extractPronouns.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ const validFields = [
"pronomen",
"Pronouns / Pronomen",
];
const invalidFields = ["pronounciation"];

for (const field of validFields) {
extract(`${field} is extracted`, async () => {
Expand All @@ -23,6 +24,17 @@ for (const field of validFields) {
});
}

for (const field of invalidFields) {
extract(`${field} is not extracted`, async () => {
const result = await pronouns.extractFromStatus({
account: {
fields: [{ name: field, value: "pro/nouns" }],
},
});
assert.equal(result, null);
});
}

extract.run();

const valueExtractionSuite = suite("value extraction");
Expand Down
Loading