-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Development Environment with Docker Hot Reload and Update Contributing Guidelines #280
base: master
Are you sure you want to change the base?
Conversation
Nice PR! This feature is much needed for the project |
@ItzCrazyKns What do you think? |
LGTM but do we really need Docker for development? |
Yeah its helpful and would make it easier for new developers to make contributions |
Hello, if there is to be a dev environment config, I think it must be in devcontainer format. It's easy to create, easy to use and is becoming the standard. https://code.visualstudio.com/docs/devcontainers/containers |
Hello, Thank you for the feedback regarding the use of Dev Containers. While I understand the benefits of using Dev Containers, there are several disadvantages that I personally face as I work remotely from multiple devices:
Given these considerations, I believe it is beneficial to support both Docker Development Environment and Dev Containers by default. This approach provides flexibility for contributors to choose the setup that best fits their needs and working conditions. What do you think @nnWhisperer @ItzCrazyKns, I work remotely from multiple machines and I want to make a lot of contributions to this project as I use it almost daily. Having support for both Docker Development Environment and Dev Containers by default would be amazing and would greatly enhance my ability to contribute effectively. Thanks for the amazing project @ItzCrazyKns ! So consider merging this pull request to provide a more flexible and inclusive development environment for all contributors. |
Overview
This pull request introduces a significant improvement to the Perplexica project's development environment and contribution process. It addresses and closes issue #277 by implementing a Docker-based development setup with hot reloading capabilities, making it easier for contributors to get started and work efficiently.
Closes #277
Key Changes
Docker Development Environment
docker-compose.dev.yaml
for a consistent and easy-to-setup development environmentpackage.json
modifications in root orui
directory prompt container rebuildsUpdated CONTRIBUTING.md
Additional Improvements
Benefits
Next Steps
I'm excited to contribute to Perplexica and hope these changes will make it easier for others to join in and improve this fantastic project. I'm open to any feedback or suggestions for further enhancements.
Thank you for considering this contribution!