Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ext-ds to replace array to vector for performance optimization #122

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SmetDenis
Copy link
Member

The PHP 'ds' (data structures) extension has been added to the GitHub Actions workflows to permit targeting PHP 8.3. Array references in all aggregate rule classes have also been migrated to Ds\Vector. With this change, memory optimization and performance are expected to be enhanced due to the characteristic efficiency of vectors.

The PHP 'ds' (data structures) extension has been added to the GitHub Actions workflows to permit targeting PHP 8.3. Array references in all aggregate rule classes have also been migrated to Ds\Vector. With this change, memory optimization and performance are expected to be enhanced due to the characteristic efficiency of vectors.
@SmetDenis SmetDenis marked this pull request as draft April 1, 2024 19:11
@SmetDenis SmetDenis changed the title Add 'ds' PHP extension and transition array to vector WIP: Add 'ds' PHP extension and transition array to vector Apr 2, 2024
@SmetDenis SmetDenis added the WIP Work in progress label Apr 2, 2024
@SmetDenis SmetDenis changed the title WIP: Add 'ds' PHP extension and transition array to vector Add 'ds' PHP extension and transition array to vector Apr 2, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@SmetDenis SmetDenis changed the title Add 'ds' PHP extension and transition array to vector Add ext-ds to replace array to vector for performance optimization Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Development

Successfully merging this pull request may close these issues.

1 participant