Update terminal width for GitHub actions and adjust schema examples #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 14, 2024 04:29
This commit adjusts the terminal width configuration in ErrorSuite.php specifically for GitHub actions by adding a condition to set the maximum width to 150. Furthermore, the order of "str_ends_with" and "str_starts_with" properties in full.yml schema example file have been switched. Relevant changes are also echoed in the README.md file.
The order of "str_ends_with" and "str_starts_with" properties in both full.json and full.php has been swapped for consistency and clarity. The README.md documentation has been updated to reflect these modifications in the schema examples.
Pull Request Test Coverage Report for Build 8277592995Details
💛 - Coveralls |
added 7 commits
March 14, 2024 04:34
The usage syntax for csv-blueprint has been updated in the GithubActionsTest.php and README.md file to specify 'master' branch. This ensures that users always fetch the latest version when using the csv-blueprint action.
The terminal width determination code in ErrorSuite.php has been updated to include a check for a Docker environment. Additionally, utility methods for checking the Docker environment and Github Actions have been added in Utils.php for reusability. These changes will help refine terminal width estimates and enhance code organization.
The terminal width determination code in ErrorSuite.php has been updated to consider Docker environments. A new method, autoDetectTerminalWidth(), has been added for this functionality. Furthermore, in Utils.php, the isGithubActions() now includes a Docker environment check ensuring the functionality considers both contexts. This enhances reusability and precision in terminal width estimation.
String validation rules 'str_starts_with' and 'str_ends_with' were renamed to 'starts_with' and 'ends_with' for brevity and consistency. Also, a new utilitarian method named 'autoDetectTerminalWidth' was introduced to accurately estimate terminal width based on the execution environment. The code now takes into account wider terminal widths in Docker and GitHub actions environments.
The maximum auto-detected terminal width is adjusted for Docker containers from 120 characters to 140 characters. This considers the possibility of wider terminals in Docker environments, ensuring that the terminal output better accommodates for additional space.
Removed the assignment of the terminal width auto-detection to a variable in ErrorSuite.php and instead directly used it in the limit calculation. To improve clarity and maintain cleanliness of the code, comments related to terminal width auto-detection fall back have been moved to inside the autoDetectTerminalWidth function in Utils.php.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts the terminal width configuration in ErrorSuite.php specifically for GitHub actions by adding a condition to set the maximum width to 150. Furthermore, the order of "str_ends_with" and "str_starts_with" properties in full.yml schema example file have been switched. Relevant changes are also echoed in the README.md file.