-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix not found request for forward response #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test report for commit af817bf. All test cases passed! Successful Test Cases
|
Integration test report for commit af817bf. All test cases passed! Successful Test Cases
|
JackyWoo
reviewed
Oct 17, 2024
JackyWoo
reviewed
Oct 18, 2024
There is a little issue in CI that the failed test report does not squash test cases with different sanatize types. We could fix it in another PR. |
JackyWoo
reviewed
Oct 18, 2024
JackyWoo
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issues of this PR fixes:
This PR try to fix #350, fix #348
Change log:
forward_request_queue
before forward request to leaderpending_request-> create_time
(self's steady_clock) instead ofcommitted_request-> create_time
(leader's steady_clock) to calculate request time costforward request
,forward response
printing in logs