Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added phases to InfiniteGratingMOTBeams #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pelgee
Copy link

@pelgee pelgee commented Jan 28, 2023

No description provided.

@dsbarker
Copy link
Member

Can you pull v103_bug_fixes, cherry pick your commit to that branch, and resubmit? We try to keep new code out of master until we're ready for a new release.

Also, can you add

if diff_phases is None:
            diff_phases = np.zeros(nr)

after line 103?

@dsbarker dsbarker self-assigned this Jan 30, 2023
@dsbarker dsbarker added this to the 1.0.3 milestone Jan 31, 2023
@dsbarker dsbarker added the enhancement New feature or request label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants