Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winget-release github action #169

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jo-chemla
Copy link

Description:

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@jo-chemla
Copy link
Author

jo-chemla commented Nov 12, 2024

According to the list of recent Github Actions runs, it looks that a maintainer needs to validate the winget-release. Note as mentioned in the original linked issue #168 that when merging this PR, you will need to proceed with a few steps for the final workflow to run smoothly and automatically on every github release:

  • You will need to create a classic Personal Access Token (PAT) with public_repo scope.
  • This token should be added as a repository secret by creating a new repo secret with name WINGET_ACC_TOKEN and value the token
  • Fork microsoft/winget-pkgs under the same account/organization as the project's repository. If you are forking winget-pkgs on a different account (e.g. bot/personal account), you can use the fork-user input to specify the username of the account where the fork is present.

image

@Jacalz
Copy link
Owner

Jacalz commented Nov 12, 2024

Sorry for the slow response. I have been rather busy and forgot about reviewing this. Will have a look as soon as I have some time over. Thanks for working on this.

@Jacalz
Copy link
Owner

Jacalz commented Dec 20, 2024

Hi again. I have now released v3.7.0 with and important dependency fix which makes the project buildable again after a dependency changed its import path so this seems relevant to look at again. Is it possible to make this build the application directly instead of just pulling down a pre-built exe? Doing the latter seems to me like it adds no very little compared to the time I have to put into maintaining this. Especially for an operating system that I neither like, use nor have easy access to for testing purposes.

@Jacalz
Copy link
Owner

Jacalz commented Dec 20, 2024

See https://github.com/Jacalz/rymdport/releases/tag/v3.7.0 for more information as to why I would prefer it to build directly. I am a bit tired of managing cross-compilation toolchains on my end.

@jo-chemla
Copy link
Author

Hi there, thanks for getting back and congrats on the 3.7.0 release. The winget-pkgs repo only accepts pre-builts installers or executables - eventually zipped - and the PR I made looks for one or more exes in the github release to push these new version packages to winget-pkgs.

If you first want github to build these executables for eg the windows platform, this is probably doable via another github action. Github has a dedicated post regarding go build Github Action workflow CI here, this is probably where you'd like to have a look first.

@Jacalz
Copy link
Owner

Jacalz commented Dec 20, 2024

Thanks.

Hmm. Only allowing .exe files from a random location seems like a supply chain attack waiting to happen. Anyway, not my problem to worry about :)

Thanks for the hint about GitHub CI. That might fix half of the problem but I suppose it still would be needed to do cross-compiling for other architectures like arm64 unfortunately :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants