-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QA-15348: Fixes for the condition property of json overrides #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gflores-jahia
changed the title
QA-15348 Fixes for the condition property of json overrides
QA-15348: Fixes for the condition property of json overrides
Oct 29, 2024
gflores-jahia
force-pushed
the
QA-15348
branch
from
October 30, 2024 15:41
5af676e
to
a389b00
Compare
gflores-jahia
force-pushed
the
QA-15348
branch
from
October 31, 2024 13:39
d11f4b2
to
0c2c09a
Compare
gflores-jahia
force-pushed
the
QA-15348
branch
2 times, most recently
from
October 31, 2024 18:24
0bb5ac8
to
ebba60b
Compare
gflores-jahia
force-pushed
the
QA-15348
branch
from
October 31, 2024 19:31
ebba60b
to
0cb0246
Compare
@@ -126,7 +133,7 @@ describe('Test Choicetree selector type', () => { | |||
choiceTree.getEntries().should('contain', 'choiceTreeContent2'); | |||
}); | |||
|
|||
it.only('displays the Choice tree selector for single value', () => { | |||
it.skip('displays the Choice tree selector for single value', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled for now as this is flaky even on nightly. Will create separate ticket.
AKarmanov
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://jira.jahia.org/browse/QA-15348
Description
Tests
The following are included in this PR
Checklist
I have considered the following implications of my change:
Documentation