Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA-15348: Fixes for the condition property of json overrides #1323

Merged
merged 7 commits into from
Nov 1, 2024

Conversation

r3dm1ke
Copy link
Contributor

@r3dm1ke r3dm1ke commented Oct 24, 2024

JIRA

https://jira.jahia.org/browse/QA-15348

Description

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

@gflores-jahia gflores-jahia changed the title QA-15348 Fixes for the condition property of json overrides QA-15348: Fixes for the condition property of json overrides Oct 29, 2024
@gflores-jahia gflores-jahia marked this pull request as ready for review November 1, 2024 12:32
@gflores-jahia gflores-jahia requested a review from a team November 1, 2024 12:33
@@ -126,7 +133,7 @@ describe('Test Choicetree selector type', () => {
choiceTree.getEntries().should('contain', 'choiceTreeContent2');
});

it.only('displays the Choice tree selector for single value', () => {
it.skip('displays the Choice tree selector for single value', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disabled for now as this is flaky even on nightly. Will create separate ticket.

@gflores-jahia gflores-jahia merged commit 943d560 into master Nov 1, 2024
18 checks passed
@gflores-jahia gflores-jahia deleted the QA-15348 branch November 1, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants