Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKLOG-23210 Flush page and site cache #1325

Merged
merged 8 commits into from
Nov 4, 2024
Merged

BACKLOG-23210 Flush page and site cache #1325

merged 8 commits into from
Nov 4, 2024

Conversation

AKarmanov
Copy link
Contributor

JIRA

https://jira.jahia.org/browse/BACKLOG-23210

Description

Flush page and site cache. Address some minor button, styling issues

@AKarmanov AKarmanov marked this pull request as ready for review October 30, 2024 15:11
@AKarmanov AKarmanov requested a review from a team October 31, 2024 14:01
Copy link
Contributor

@gflores-jahia gflores-jahia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're mixing fixes for the edit/live comparison with the flush cache implementation. Could we create a separate PRs for the edit/live and flush cache? This way, it's easier to trace the commits/PR and accurate links with the stories.

@AKarmanov
Copy link
Contributor Author

It looks like we're mixing fixes for the edit/live comparison with the flush cache implementation. Could we create a separate PRs for the edit/live and flush cache? This way, it's easier to trace the commits/PR and accurate links with the stories.

I kept them here as they are small two liners instead of opening 3 separate PRs, I figured they were small enough to be able to tell exactly what's happening while moving things a little quicker.

Copy link
Contributor

@gflores-jahia gflores-jahia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes looks good.

Sorry, I know it's a pain but I would insist on creating a separate PR for the live/edit action changes. I know it can sometimes happen by accident, but we should try to not mix up our stories with code changes as it makes the history of code changes confusing, we lose track of the ticket source that could have additional discussions, regarding the changes and harder to trace the reason/context on why we made those changes (checking for regression scenarios, etc).

It doesn't have to be 3 separate PRs but we can group them together on a single one as it's all dealing with a single topic.

@AKarmanov AKarmanov merged commit 63205cc into master Nov 4, 2024
16 of 18 checks passed
@AKarmanov AKarmanov deleted the BACKLOG-23210 branch November 4, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants