Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BACKLOG-21332: skip reset when only query string is changed #909

Merged
merged 1 commit into from
Aug 1, 2023
Merged

BACKLOG-21332: skip reset when only query string is changed #909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/javascript/ContentEditor/ContentEditorApi/ContentEditorApi.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
// Add hash to history only if full screen configuration available, otherwise update config state directly
if (currentEncodedLocation !== locationFromState && locationFromState.includes('contentEditor:') && locationFromState.includes('isFullscreen:!!t')) {
if (currentEncodedLocation.includes('contentEditor:')) {
// Todo : handle the case when stacking a new content-editor - we should push

Check warning on line 109 in src/javascript/ContentEditor/ContentEditorApi/ContentEditorApi.jsx

View workflow job for this annotation

GitHub Actions / Static Analysis (linting, vulns) 

Unexpected 'todo' comment: 'Todo : handle the case when stacking a...'
history.replace(rison.decode(locationFromState));
} else {
history.push(rison.decode(locationFromState));
Expand Down Expand Up @@ -137,7 +137,7 @@
if (loaded.current) {
unsetEditorConfigs();
}
}, [history, location.pathname, locationWithoutEditors]); // eslint-disable-line
}, [location.pathname]); // eslint-disable-line

useEffect(() => {
loaded.current = true;
Expand Down Expand Up @@ -189,7 +189,7 @@
{editorConfigs.map((editorConfig, index) => {
return (
<ContentEditorModal
key={editorConfig.mode + '_' + editorConfig.uuid} // TODO: best effort to have a unique KEY for modals (definitely we need control to allow or not open same modal or multiple create at the same time.)

Check warning on line 192 in src/javascript/ContentEditor/ContentEditorApi/ContentEditorApi.jsx

View workflow job for this annotation

GitHub Actions / Static Analysis (linting, vulns) 

Unexpected 'todo' comment: 'TODO: best effort to have a unique KEY...'
editorConfig={editorConfig}
updateEditorConfig={updatedEditorConfig => {
updateEditorConfig(updatedEditorConfig, index);
Expand Down
Loading