Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKLOG-21361: Replaced most of systemName adapter by override #924

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

tdraier
Copy link
Contributor

@tdraier tdraier commented Aug 3, 2023

JIRA

https://jira.jahia.org/browse/BACKLOG-21361

Description

Main goal is to be able to use override to defined labels/description of system name - and at the same time, use same overrides to define other properties.

  • Cleaned adaptSystemNameField from all stuff that could be replaced easily with overrides : label keys, read only (basic cases), selector options. Name initialization moved to getInitialValues().
  • Fixed label key inconsistencies. Key format with "@" was decoded in unexpected order ( key location was before @ symbol ), generated keys was not in the same order, and resource bundle name was randomly replaced by osgi bundle name. In the end, replaced with ":" separator which has a clearer meaning ( module-name:label-key ), not using resource bundle names at all.
  • Set "module-name" in all label keys to the bundle owning the json file as default, if not already set.
  • Use substitutor on label and selection options values to be able to use the maxNameSize from jahia.properties.
  • Adapted the json files for nt:base, jnt:page and jmix:systemNameReadOnly

@tdraier tdraier requested a review from a team as a code owner August 3, 2023 16:57
@tdraier tdraier merged commit 335f4aa into master Aug 4, 2023
5 of 6 checks passed
@tdraier tdraier deleted the BACKLOG-21361 branch August 4, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants