Add authentication option and some support to path-like s3 uri-s for region specification #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Stephan,
please find a draft solution for having both the authentication and the region passing through N5Factory.
I added a cmd line option to explicitly request the authentication from the backend (at the moment s3 only). This is necessary for the output bucket writing, because the credentials are based on the assumed role in the EMR-serverless session.
Unless the path-like s3 uri (
https://s3-us-west-2.amazonaws.com/bucket/...
) is used, N5Factory falls back tous-east-1
which does not work for us. UpdatedParsedBucket
to tolerate path-like uri-s. Maybe we don't really want to use path-like URI-s in the long term but using N5Factory.s3Region to set region obtained from theDefaultAwsRegionProviderChain
. See related issue here.Also note that while this branch works with n5-aws-s3 4.1.1, it fails with key error in 4.1.3 :