Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2 JanusGraph presentations to index.md #26

Merged
merged 1 commit into from
Sep 15, 2017

Conversation

sumalaika
Copy link
Contributor

Signed-off-by: Susan Malaika [email protected]

@janusgraph-bot
Copy link

Please verify the committer name, email, and GitHub username association are all correct and match CLA records.

@mbrukman
Copy link
Member

OK, I don't know what's going on here, @sumalaika -- it looks like your commit exactly matches what's in CLA_SIGNERS.yaml.

Let me investigate this further, no need for you to do anything at this time. Sorry for the trouble!

@sumalaika
Copy link
Contributor Author

@mbrukman - any news? can I proceed?

@sumalaika
Copy link
Contributor Author

@mbrukman - I'd like to add lists of presentations. Can I proceed?

@mbrukman
Copy link
Member

@sumalaika — sorry for the delay. This looks like an issue in GitHub API: the PR submitter is not being recorded, so it cannot be programmatically verified, even though it's clear (to a human) that you're the author of this PR via the GitHub UI. I will file a support ticket with GitHub and cc: you on it.

We've seen this happen in the past; it's something that only GitHub admins can fix for us.

@mbrukman
Copy link
Member

Previous instance when this happened as well: JanusGraph/janusgraph#96 (comment)

I've filed a support ticket with GitHub requesting them to fix it as they did previously, and asked how we can avoid this issue in the future. @sumalaika: I've cc'd you in the report; not sure if that means you'll be cc'd on the email and their responses as well.

@mbrukman
Copy link
Member

Update: GitHub support replied, I provided more information on what is the issue. For future reference, the concrete issue here is:

If we look at commits for PR #26, we find a single commit and looking at what the API returns for this commit, we see:

"author": null,
"committer": null,

In contrast, looking at commits for PR #27, we also find a single commit and looking at what the API returns for this commit, we see that it is a much more complete response:

"author": {
  "login": "mbrukman",
  [...lots more here...]
},
"committer": {
  "login": "mbrukman",
  [...lots more here...]
},

GitHub support mentioned that last time that happened (in the previous instance I mentioned earlier), the developer did not associate their email address with their GitHub account. @sumalaika, did you associate your work email address with your GitHub account?

Copy link
Member

@mbrukman mbrukman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbrukman mbrukman merged commit 54ab063 into JanusGraph:master Sep 15, 2017
@mbrukman
Copy link
Member

This PR partially addresses issue #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants