Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

글로벌 스타일 설정 #18

Merged
merged 2 commits into from
Oct 27, 2023
Merged

글로벌 스타일 설정 #18

merged 2 commits into from
Oct 27, 2023

Conversation

imb96
Copy link
Contributor

@imb96 imb96 commented Oct 26, 2023 •
edited by 1g2g
Loading

⚙️ PR 타입

  • Feature
  • Hotfix

✨ 기능 설명 or 🚨 문제 상황

글로벌 스타일을 추가했습니다.

👨‍💻 구현 내용 or 👍 해결 내용

reset.css CDN 추가 했습니다.
gmarketsans 폰트 추가 했습니다.
emotion theme 적용 했습니다.

🎯 PR 포인트

사용하시는 방법.

const ButtonStyle = styled.button`
  font-size: ${({ theme }) => theme.FONT_SIZE.LG};
  color: ${({ theme }) => theme.PALETTE.WHITE};
`;

📝 참고 사항

❓ 궁금한 점

#6 close

@imb96 imb96 added the 스타일링 css 관련한 부분을 수정합니다. label Oct 26, 2023
@imb96 imb96 added this to the 1차 스프린트 milestone Oct 26, 2023
@imb96 imb96 assigned imb96 and 1g2g Oct 26, 2023
@imb96 imb96 linked an issue Oct 26, 2023 that may be closed by this pull request
글로벌 스타일 설정 #6
Closed
@1eecan
Copy link
Contributor

1eecan commented Oct 26, 2023

🎉 @1g2g 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

@1eecan 1eecan requested a review from 1g2g October 26, 2023 09:33
@1g2g 1g2g changed the title feat: #6 글로벌 스타일 글로벌 스타일 설정 Oct 27, 2023
dlwl98
dlwl98 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@dlwl98 dlwl98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK!

@dlwl98 dlwl98 merged commit afcf152 into dev Oct 27, 2023
1g2g pushed a commit that referenced this pull request Oct 29, 2023
@imb96 @dlwl98 @1g2g
feat: #6 글로벌 스타일 (#18)
55f404d 
Co-authored-by: 이진욱 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwl98 dlwl98 dlwl98 approved these changes

@1g2g 1g2g Awaiting requested review from 1g2g

Assignees

@imb96 imb96

@1g2g 1g2g

Labels
스타일링 css 관련한 부분을 수정합니다.
Projects
None yet
Milestone
1차 스프린트
Development

Successfully merging this pull request may close these issues.

글로벌 스타일 설정
4 participants
@imb96 @1eecan @dlwl98 @1g2g