Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image, Avatar, AvatarGroup 공통 컴포넌트 구현 #28

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

dlwl98
Copy link
Member

@dlwl98 dlwl98 commented Oct 28, 2023

⚙️ PR 타입

  • Feature
  • Hotfix

✨ 기능 설명 or 🚨 문제 상황

feat: Image 공통 컴포넌트 구현
feat: Avatar 공통 컴포넌트 구현
feat: AvatarGroup 공통 컴포넌트 구현

👨‍💻 구현 내용 or 👍 해결

스크린샷 2023-10-28 오후 9 24 41

code

<AvatarGroup
  size={30}
  radius="50%"
  border={`1px solid ${PALETTE.GRAY_400}`}
  overlap={10}
>
  <Avatar src="https://picsum.photos/500" />
  <Avatar src="https://picsum.photos/500" />
  <Avatar src="https://picsum.photos/500" />
  <Avatar src="https://picsum.photos/500" />
  <Avatar src="https://picsum.photos/500" />
</AvatarGroup>
스크린샷 2023-10-28 오후 9 30 21

code

import Ball from '@assets/ball.svg';

<Avatar src={Ball} size={100} radius="16px" border="2px solid black" />

🎯 PR 포인트

📝 참고 사항

Image 컴포넌트의 width, height값을 number로 받을 시 내부에서 rem으로 변경됩니다.

❓ 궁금한 점

#23 close
#24 close

@dlwl98 dlwl98 added the 기능 코드의 기능이 추가되거나 바뀌었습니다. label Oct 28, 2023
@dlwl98 dlwl98 self-assigned this Oct 28, 2023
@1eecan
Copy link
Contributor

1eecan commented Oct 28, 2023

🎉 @dlwl98 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

Copy link
Member

@1g2g 1g2g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! LGTM입니다🔥

display: ${({ block }) => (block ? 'block' : 'inline')};
width: ${({ width }) => width};
height: ${({ height }) => height};
object-fit: ${({ mode }) => mode};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dlwl98 dlwl98 merged commit 2fa9a50 into dev Oct 30, 2023
@dlwl98 dlwl98 deleted the feat/#24-avatar-group-component branch October 30, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
기능 코드의 기능이 추가되거나 바뀌었습니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants