Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatchItem 공통 컴포넌트 구현 #30

Merged
merged 8 commits into from
Oct 30, 2023
Merged

Conversation

dlwl98
Copy link
Member

@dlwl98 dlwl98 commented Oct 28, 2023

⚙️ PR 타입

  • Feature
  • Hotfix

✨ 기능 설명 or 🚨 문제 상황

feat: WEEKDAY 상수 추가
feat: MatchItem 공통 컴포넌트 구현
feat: MatchItem 컴포넌트 클릭 핸들러 추가

👨‍💻 구현 내용 or 👍 해결 내용

스크린샷 2023-10-29 오전 12 21 48
<MatchItem
  matchId="1"
  startTime={new Date()}
  timeMinutes={60}
  mainAddress="서울특별시 송파구 송파나루길 206"
  memberCount={6}
  maxMemberCount={10}
  membersProfileImageUrls={[
    'https://picsum.photos/500',
    'https://picsum.photos/500',
    'https://picsum.photos/500',
    'https://picsum.photos/500',
    'https://picsum.photos/500',
    'https://picsum.photos/500',
  ]}
>
  <MatchItem.ManageBtn onClick={() => {}} /> // 매치관리 버튼 필요할 시
</MatchItem>

// 또는

<MatchItem
  matchId="1"
  startTime={new Date()}
  timeMinutes={60}
  mainAddress="서울특별시 송파구 송파나루길 206"
  memberCount={6}
  maxMemberCount={10}
  membersProfileImageUrls={[
    'https://picsum.photos/500',
    'https://picsum.photos/500',
    'https://picsum.photos/500',
    'https://picsum.photos/500',
    'https://picsum.photos/500',
    'https://picsum.photos/500',
  ]}
/>

🎯 PR 포인트

📝 참고 사항

아직 프로필 이미지들을 보여주는 기능은 없습니다.
AvatarGroup 컴포넌트가 머지되면 추가 예정입니다.

글로벌 스타일을 조금 수정했습니다.
design: body 태그 margin 제거

Layout 컴포넌트를 조금 수정했습니다.
design: Layout 컴포넌트 높이 100%로 지정

❓ 궁금한 점

#29 close

@dlwl98 dlwl98 added the 기능 코드의 기능이 추가되거나 바뀌었습니다. label Oct 28, 2023
@dlwl98 dlwl98 self-assigned this Oct 28, 2023
@1eecan
Copy link
Contributor

1eecan commented Oct 28, 2023

🎉 @dlwl98 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏

Copy link
Contributor

@imb96 imb96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment on lines 3 to 4
import { PALETTE } from '@styles/palette';
import { STYLES } from '@styles/styles';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme provider를 적용했기때문에 import 없이 사용하실 수 있습니다.

Comment on lines 14 to 22
export const MatchStatus = styled.div`
${STYLES.FLEX_CENTER}
flex-direction: column;
background-color: ${PALETTE.GRAY_100};
padding: 10px;
width: 82px;
height: 82px;
border-radius: 8px;
`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theme사용해서 변경할 수 있습니다.

Suggested change
export const MatchStatus = styled.div`
${STYLES.FLEX_CENTER}
flex-direction: column;
background-color: ${PALETTE.GRAY_100};
padding: 10px;
width: 82px;
height: 82px;
border-radius: 8px;
`;
export const MatchStatus = styled.div`
${({theme}) => theme.STYLES.FLEX_CENTER}
flex-direction: column;
background-color: ${({theme}) => theme.PALETTE.GRAY_100}
padding: 10px;
width: 82px;
height: 82px;
border-radius: 8px;
`;

@dlwl98 dlwl98 merged commit 85e1274 into dev Oct 30, 2023
@dlwl98 dlwl98 deleted the feat/#29-matchitem-component branch October 30, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
기능 코드의 기능이 추가되거나 바뀌었습니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants