하단 navbar 구현 #31
Merged
하단 navbar 구현 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
🎉 @1eecan 님 랜덤 리뷰어로 당첨되셨습니다! 리뷰를 부탁드립니다. 🙏 |
|
바뀌어야하는 컴포넌트에 key로 location.pathname을 넣어보실래요? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ PR 타입
✨ 기능 설명 or 🚨 문제 상황
하단 navbar를 구현했습니다
👨💻 구현 내용 or 👍 해결 내용
feat: navbar 추가
style: navbar.style.ts 추가
fix: Layout.tsx Navbar component 연동
🎯 PR 포인트
max-width를 아이폰13 미니 기준으로 맞추었습니다.
📝 참고 사항
Layout.tsx를 건들여서 충돌이 일어날 수 있습니다.
논의 후 Layout.tsx는 merge에서 빼도 좋을 것 같습니다.
메세지와 지도는 라우팅 처리가 되지 않아서 누르면 에러가 발생합니다.
현재 상위페이지에서 하위페이지로 들어가면 버튼 아이콘 색깔이 빨간색이 되지 않네요
ex) /create -> 빨강, /create/game -> 빨강아님
리팩토링 추후에 진행하겠습니다.
❓ 궁금한 점
#25 close