로그인 필요한 페이지들 리디렉션 기능 추가 #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1g2g
approved these changes
Nov 26, 2023
There was a problem hiding this comment.
MenuItem에 color 속성을 추가하면서 onClickMenuItem={() => moveToPage(PATH_NAME.CHAT)}이 같이 복붙된 것 같아요
There was a problem hiding this comment.
useChatRoomListPage.ts에서 충돌이 나서 conflict 풀었습니다🙇
There was a problem hiding this comment.
MenuItem에 color 속성을 추가하면서 onClickMenuItem={() => moveToPage(PATH_NAME.CHAT)}이 같이 복붙된 것 같아요
어느 부분일까요 ㅠㅠ 못찾겠어요
There was a problem hiding this comment.
푸시 오류나서 push -f 했더니 다시 confict 생겼습니다. 하하...
dlwl98
force-pushed
the
feat/#334-redirect
branch
from
ebf83d0
to
ee141b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚙️ PR 타입
✨ 기능 설명 or 🚨 문제 상황
로그인 필요한 페이지들 리디렉션 기능 추가
👨💻 구현 내용 or 👍 해결 내용
비로그인 시 로그인 필요한 버튼들 색 변경했습니다.
동영상은 strict mode로 인해 toast가 두번 됩니다.
feat: LoginRequireBoundary 구현
feat: 전체 서비스 페이지 비로그인 스타일 추가
feat: 로그인 필요 시 LoginRequireError 를 throw 하도록 수정
fix: 렌더링 로직 effect 안으로 이동
2023-11-24.8.39.32.mov
🎯 PR 포인트
📝 참고 사항
❓ 궁금한 점