-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
로그인 필요한 페이지들 리디렉션 기능 추가 #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MenuItem에 color 속성을 추가하면서 onClickMenuItem={() => moveToPage(PATH_NAME.CHAT)}
이 같이 복붙된 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
useChatRoomListPage.ts
에서 충돌이 나서 conflict 풀었습니다🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MenuItem에 color 속성을 추가하면서 onClickMenuItem={() => moveToPage(PATH_NAME.CHAT)}이 같이 복붙된 것 같아요
어느 부분일까요 ㅠㅠ 못찾겠어요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
찾았습니다. 수정할게요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
푸시 오류나서 push -f 했더니 다시 confict 생겼습니다. 하하...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭
ebf83d0
to
ee141b3
Compare
⚙️ PR 타입
✨ 기능 설명 or 🚨 문제 상황
로그인 필요한 페이지들 리디렉션 기능 추가
👨💻 구현 내용 or 👍 해결 내용
비로그인 시 로그인 필요한 버튼들 색 변경했습니다.
동영상은 strict mode로 인해 toast가 두번 됩니다.
feat: LoginRequireBoundary 구현
feat: 전체 서비스 페이지 비로그인 스타일 추가
feat: 로그인 필요 시 LoginRequireError 를 throw 하도록 수정
fix: 렌더링 로직 effect 안으로 이동
2023-11-24.8.39.32.mov
🎯 PR 포인트
📝 참고 사항
❓ 궁금한 점