-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix small issues, mostly docs (fixes #434) #435
Conversation
Choosing a time range | ||
************************* | ||
|
||
The time range depends on the expected range of distances, but is typically in the range of 0.5 to several microseconds. To construct a time vector, use the ``linspace`` function from NumPy: :: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure of this wording here. When creating the model you have already got your data, so you aren't so much choosing your time range more inputting it. I also wouldn't say that the time range is dependent on the distances, more the range of extractable distances is dependent upon the time axis.
Additionally most people use a tau1 of 0.4us for 4pDEER, so the range starts before 0.5 us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good except I don't fully agree with the language around 'Choosing a time range'.
I modified the language. Good now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks.
No description provided.