Refactor UIKit interop implementation #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Jun 19, 2024
Comment on lines
161
to
140
| EmptyLayout( | ||
| modifier.onGloballyPositioned { coordinates -> | ||
| val finalModifier = modifier |
There was a problem hiding this comment.
It was easier without extra val
There was a problem hiding this comment.
Way too much indentation and it's an idiom used in the common source set as well
There was a problem hiding this comment.
indentation is the same, isn't it?
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/interop/UIKitView.uikit.kt
Outdated
Show resolved
Hide resolved
|
I'll do some more stuff along this PR |
elijah-semyonov
force-pushed
the
es/refactor-uikit-interop
branch
from
1a15002
to
ea777e1
Compare
elijah-semyonov
force-pushed
the
es/refactor-uikit-interop
branch
from
c0a212b
to
9859fff
Compare
MatkovIvan
reviewed
Jun 26, 2024
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/node/InteropContainer.skiko.kt
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/interop/UIKitInteropContainer.uikit.kt
Outdated
Show resolved
Hide resolved
ASalavei
approved these changes
Jun 26, 2024
| @@ -38,35 +40,124 @@ internal val LocalUIKitInteropContainer = staticCompositionLocalOf<UIKitInteropC | |||
| error("UIKitInteropContainer not provided") | |||
| } | |||
|
|
|||
|
|
|||
| internal enum class UIKitInteropState { | |||
There was a problem hiding this comment.
IMHO, interop and enum values are too generic.
Could you please add brief comment explaining why this enum used?
MatkovIvan
requested changes
Jun 27, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/interop/UIKitInteropContainer.uikit.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Jun 27, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/window/RenderingUIView.uikit.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor UIKit interop implementation:
UIKitViewandUIKitViewControllercommon part toUIKitInteropLayout.InteropComponentHandler.UIKitInteropContextintoUIKitInteropContainer.