Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly merge ExposedDropdownMenu from Material 3 1.3 #1423

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

MatkovIvan
Copy link
Member

@MatkovIvan MatkovIvan commented Jun 27, 2024

Missing changes during Material 3 1.3 merge

Fixes JetBrains/compose-multiplatform#4782
Fixes JetBrains/compose-multiplatform#5033

Release Notes

Fixes - Multiple Platforms

  • Fix focus for editable TextField inside ExposedDropdownMenuBox

@@ -107,7 +108,7 @@ internal fun TextFieldWithExposedDropdown() {
onExpandedChange = { expanded = !expanded },
) {
TextField(
modifier = Modifier.menuAnchor(),
modifier = Modifier.menuAnchor(MenuAnchorType.PrimaryNotEditable),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add examples of the other two MenuAnchorTypes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we have a lot of new elements that should be tested/covered. Let's do it separately from the merge (and fixing bad merge)

@MatkovIvan MatkovIvan merged commit ed91690 into jb-main Jun 28, 2024
8 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-material3-ExposedDropdownMenu branch June 28, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants