Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better ComposeScene naming #1424

Merged
merged 8 commits into from
Jul 9, 2024
Merged

Better ComposeScene naming #1424

merged 8 commits into from
Jul 9, 2024

Conversation

MatkovIvan
Copy link
Member

  • MultiLayerComposeScene -> CanvasLayersComposeScene
  • SingleLayerComposeScene -> PlatformLayersComposeScene
  • Change deprecation level to ERROR for old ComposeScene

JakeWharton
JakeWharton reviewed Jun 27, 2024
View reviewed changes
...ose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/scene/PlatformLayersComposeScene.skiko.kt
density: Density = Density(1f),
layoutDirection: LayoutDirection = LayoutDirection.Ltr,
size: IntSize? = null,
coroutineContext: CoroutineContext = Dispatchers.Unconfined,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now would be a good time to change this default here and on CanvasLayersComposeScene

JetBrains/compose-multiplatform#4799

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks for reminder

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussions with @igordmn and @m-sasha we didn't agree what should be used as a default value here instead. So it was postponed and moved out of the scope of this PR - we'll have some room to do that before 1.7 stable without breaking compatibility

@MatkovIvan MatkovIvan force-pushed the ivan.matkov/better-composescene-naming branch from fada539 to bc03502 Compare July 9, 2024 11:30
@MatkovIvan MatkovIvan marked this pull request as ready for review July 9, 2024 11:31
@MatkovIvan MatkovIvan merged commit 8954720 into jb-main Jul 9, 2024
6 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/better-composescene-naming branch July 9, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeWharton JakeWharton JakeWharton left review comments

@igordmn igordmn igordmn approved these changes

@m-sasha m-sasha Awaiting requested review from m-sasha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatkovIvan @JakeWharton @igordmn