Remove interop view during un-placement #1425

MatkovIvan · 2024-06-28T08:30:20Z

Remove interop views on unplace instead of onDestroy

Before

Screen.Recording.2024-06-25.at.08.40.38.mov

After

Screen.Recording.2024-06-28.at.10.19.02.mov

Release Notes

compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/NodeCoordinator.kt

m-sasha

Also I'd recommend adding a test with the specific case that was problematic (items in a lazy layout not being removed after fast scroll).

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/node/InteropContainer.skiko.kt

MatkovIvan requested review from elijah-semyonov and m-sasha June 28, 2024 08:30

elijah-semyonov requested changes Jun 28, 2024

View reviewed changes

compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/NodeCoordinator.kt Outdated Show resolved Hide resolved

MatkovIvan force-pushed the ivan.matkov/unplace-interop branch from b917b0d to b9c1e4a Compare June 28, 2024 10:43

elijah-semyonov approved these changes Jun 28, 2024

View reviewed changes

m-sasha requested changes Jul 1, 2024

View reviewed changes

compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/node/InteropContainer.skiko.kt Show resolved Hide resolved

MatkovIvan added 2 commits July 11, 2024 10:58

Remove interop view during un-placement

3a922f1

Add test for interop unplacement

2cc6a07

MatkovIvan force-pushed the ivan.matkov/unplace-interop branch from b9c1e4a to 2cc6a07 Compare July 11, 2024 09:01

m-sasha approved these changes Jul 11, 2024

View reviewed changes

Dispatch platform independant wheel delta

c112c4d

MatkovIvan force-pushed the ivan.matkov/unplace-interop branch from 2efa30a to c112c4d Compare July 11, 2024 10:30

MatkovIvan merged commit 97f7fbd into jb-main Jul 11, 2024
6 checks passed

MatkovIvan deleted the ivan.matkov/unplace-interop branch July 11, 2024 11:18