Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support init route and direct navigation in a browser #1640

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Support init route and direct navigation in a browser #1640

merged 4 commits into from
Oct 16, 2024
+198 −34

Conversation

terrakok
Copy link
Member

@terrakok terrakok commented Oct 15, 2024 •
edited
Loading

The PR adds a default behavior (if browser route customization was not set):

  • if the init url contains a fragment with valid route
  • if user enters an url fragment with valid route

then navigate to the route

Screen.Recording.2024-10-15.at.16.22.17.mov

Testing

  • Test it on a sample project
  • Write unit tests

Release Notes

Features - Navigation

  • Navigation via a browser address field

@terrakok terrakok requested a review from eymar October 16, 2024 07:32
@terrakok terrakok merged commit ff2a1ce into jb-main Oct 16, 2024
7 checks passed
@terrakok terrakok deleted the k.tskh/web-direct-nav branch October 16, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatkovIvan MatkovIvan MatkovIvan approved these changes

@eymar eymar eymar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terrakok @MatkovIvan @eymar