Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

components[splitePane]: Feat: Add option to hide first pane in SplitPane #5051

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ahmedhosnypro
Copy link
Contributor

Proposed Changes

This PR introduces the ability to dynamically hide the first pane within a SplitPane composable. This is achieved through a new firstVisible property in SplitPaneState, allowing developers to control pane visibility. The layout logic of SplitPane has been updated to accommodate this feature.

Testing

The changes have been tested by adding interactive buttons to the demo application, enabling users to toggle the visibility of the first pane and observe the resulting behavior.

Release Notes

Features

  • Added the firstVisible property to SplitPaneState to control the visibility of the first pane in a SplitPane.

Fixes

  • Improved documentation and removed the RTL TODO.
2024-07-01.03-29-13.mp4

This commit adds the ability to hide the first pane in a SplitPane.

- Adds `firstVisible
` property to `SplitPaneState` to control the visibility of the first pane.
- Updates `SplitPane` layout to handle the visibility of the first pane.
- Adds buttons to the demo to toggle the visibility of the first pane.
Improved the button labels in the SplitPane demo to be more descriptive.
"Hide V First" and
 "Show V First" are now "Hide Left Pane" and "Show Left Pane".
"Hide H First" and "Show H First" are now "Hide Top Pane" and "Show Top Pane".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant